phpBB2 by Przemo

[Przemo]

Security issue valid for Internet Explorer all versions of phpBB < 2.0.19
Allow to read cookies of all users using Internet Explorer, so allow to log in as this user.

Open file: /includes/bbcode.php
phpBB modified by Przemo < 1.9

Kod:

Find: $patterns[] = "#\[url\]([\w]+?://[^ \"\n\r\t<]*?)\[/url\]#is"; Replace with: $patterns[] = "#\[url\]([\w]+?://([\w\#$%&~/.\-;:=,?@\]+]|\[(?!url=))*?)\[/url\]#is"; Find: $patterns[] = "#\[url\]((www|ftp)\.[^ \"\n\r\t<]*?)\[/url\]#is"; Replace with: $patterns[] = "#\[url\]((www|ftp)\.([\w\#$%&~/.\-;:=,?@\]+]|\[(?!url=))*?)\[/url\]#is";

Version 1.9 or higher

Kod:

Find: $patterns[] = "#\[url\]([\w]+?://[\w\#$%&~/.\-;:=,?@\[\]+]*?)\[/url\]#is"; Replace with: $patterns[] = "#\[url\]([\w]+?://([\w\#$%&~/.\-;:=,?@\]+]|\[(?!url=))*?)\[/url\]#is"; Find: $patterns[] = "#\[url\]((www|ftp)\.[\w\#$%&~/.\-;:=,?@\[\]+]*?)\[/url\]#is"; Replace with: $patterns[] = "#\[url\]((www|ftp)\.([\w\#$%&~/.\-;:=,?@\]+]|\[(?!url=))*?)\[/url\]#is";

Bottom for all version

Find:

Kod:

$text = bbencode_first_pass_pda($text, $uid, '/\[quote=(\\\".*?\\\")\]/is', '[/quote]', '', false, '', "[quote:$uid=\\1]");

Replace with:

Kod:

$text = bbencode_first_pass_pda($text, $uid, '/\[quote=\\\\"(.*?)\\\\"\]/is', '[/quote]', '', false, '', "[quote:$uid=\\\"\\1\\\"]");

Find:

Kod:

if ( preg_match('#\[quote=\\\"#si', $possible_start, $match) && !preg_match('#\[quote=\\\"(.*?)\\\"\]#si', $possible_start) )

Replace with:

Kod:

if ( preg_match('#\[quote=\\\"#si', $possible_start, $match) && !preg_match('#\[quote=\\\"(.*?)\\\"\]#si', $possible_start) )

Find:

Kod:

if ($close_pos = strpos($text, '"]', $curr_pos + 9))

Replace with:

Kod:

if ($close_pos = strpos($text, '"]', $curr_pos + 14))

Find:

Kod:

if (strpos(substr($text, $curr_pos + 9, $close_pos - ($curr_pos + 9)), '[quote') === false)

Replace with:

Kod:

if (strpos(substr($text, $curr_pos + 14, $close_pos - ($curr_pos + 14)), '[quote') === false)

Find:

Kod:

$possible_start = substr($text, $curr_pos, $close_pos - $curr_pos + 2);

Replace with:

Kod:

$possible_start = substr($text, $curr_pos, $close_pos - $curr_pos + 7);

Open file: /includes/functions_post.php
Find: (In 1.9 version it appear two times, replace two times)

Kod:

$html_entities_match = array('#&(?!(\#[0-9]+;))#', '#<#', '#>#'); $html_entities_replace = array('&amp;', '&lt;', '&gt;');

Replace with:

Kod:

$html_entities_match = array('#&(?!(\#[0-9]+;))#', '#<#', '#>#', '#"#'); $html_entities_replace = array('&amp;', '&lt;', '&gt;', '&quot;');

Open file: privmsg.php
Find:

Kod:

$html_entities_match = array('#&#', '#<#', '#>#'); $html_entities_replace = array('&amp;', '&lt;', '&gt;');

Replace with:

Kod:

$html_entities_match = array('#&(?!(\#[0-9]+;))#', '#<#', '#>#', '#"#'); $html_entities_replace = array('&amp;', '&lt;', '&gt;', '&quot;');

[Gadatliwa Kasia]

[Mobilemick]

Sorry in advance........

Is this code change for the new .19 patch that as been released, or is it to update .18 i was using ?


Have looked in bbcode.php and couldnt find the first line of text .

thanks
Mick

[Edel]

[Mobilemick]

sorry my Bad, didnt see

Cytat:

Version 1.9 or higher

all changed now

Mick

[melbo]

hmmm, made the corrections and now my

Kod:

[quote]text[/quote]

doesent work

[pearman]

hello folks, you also have to do this:
in bbcode.php file find:

Kod:

$text = preg_replace("/\[quote:$uid=\"(.*?)\"\]/si", $bbcode_tpl['quote_username_open'], $text);

after that add this:

Kod:

$text = preg_replace("/\[quote:$uid="(.*?)"\]/si", $bbcode_tpl['quote_username_open'], $text);

do not replace this because old quote's will stop works.
regards.

[Gadatliwa Kasia]

[Engwareion]